linux.conf.au Optimization From: Rusty Russell To: "David S. Miller" Cc: akpm@zip.com.au, torvalds@transmeta.com, linux-kernel@vger.kernel.org, k-suganuma@mvj.biglobe.ne.jp Subject: Re: [PATCH] 2.5.21 Nonlinear CPU support On Wed, 12 Jun 2002 02:26:41 -0700 (PDT) "David S. Miller" wrote: > From: Rusty Russell > Date: Wed, 12 Jun 2002 16:58:23 +1000 > > In message <20020611.021043.04190747.davem@redhat.com> you write: > > And remember, it's the anal "every microoptimization at all costs" > > people that keep the kernel sane and from running out of control bloat > > wise. > > But it also gave us crap like net/ipv4/route.c:ip_rt_acct_read() 8( > > That's far from being an attempt optimization :-) I was giving you the benifit of the doubt, that both the design (binary data from /proc) and the code (#ifdef, cpu_logical_map(0), and "256" sprinkled everywhere) were some insane attempt at speed, rather that a demonstration of sheer programming idiocy. I stand corrected 8). This papers over the damage: